More improvements #67
Merged
+13
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`node-executor` is pulling in `kitchensink-runtime` and that is not really required by `try-runtime-cli`. `node-executor` is also build for the test `Substrate` node and should not be used outside of the repo.
Otherwise you can pass `--path` and `--snapshot-path` together and get confused.
ggwpez
reviewed
Jan 16, 2024
ggwpez
approved these changes
Jan 16, 2024
|
Tests seem flakey after this change, taking a look before merging. |
liamaharon
suggested changes
Jan 16, 2024
There was a problem hiding this comment.
There's a missing host function error when running execute-block it seems @bkchr ?
I can take a closer look later this week if you don't have time
|
🙄 I know what this is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more information.